Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Extend CABPK timeout to 30m to account for etcd cluster settling in vSphere environments. #955

Conversation

randomvariable
Copy link
Contributor

Signed-off-by: Naadir Jeewa [email protected]

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #954

Describe testing done for PR

Release note


PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

in vSphere environments.

Signed-off-by: Naadir Jeewa <[email protected]>
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/955/20211022143020/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vuil vuil requested a review from a team October 28, 2021 17:44
@vuil vuil added the ok-to-merge PRs should be labelled with this before merging label Oct 28, 2021
@vuil
Copy link
Contributor

vuil commented Oct 28, 2021

Thanks for the changes, and the explanations in #954

@pydctw
Copy link
Member

pydctw commented Oct 29, 2021

/test

@pydctw
Copy link
Member

pydctw commented Oct 29, 2021

Changes looks good to me.

@vuil

  1. Is there a command to re-trigger failing tests?
  2. Looks like I don't have an access to view this file - https://storage.googleapis.com/tkg-clustergen/955/20211022143020/clustergen.diff.txt

@alfredthenarwhal
Copy link
Collaborator

@pydctw: /test
Commit: 9d08a6e

Tests failed! Build no: 955

@vuil
Copy link
Contributor

vuil commented Oct 29, 2021

Changes looks good to me.

@vuil

  1. Is there a command to re-trigger failing tests?

You can click the failed check(s), and click "rerun all jobs" on the top right. Are you seeing the option? I just reran the failed checks, and it does look like this change may be responsible for some integration/e2e tests failing

  1. Looks like I don't have an access to view this file - https://storage.googleapis.com/tkg-clustergen/955/20211022143020/clustergen.diff.txt

It's not that. The UX of the link can possibly but improved, but if the PR does not result in any differences in any cluster configuration generation, the file will show blank today.
As for why it is blank for this change, this is because clustergen only captures the dry-run output of "cluster create", iow that which is produced via yttprocessor processing the infra-specific cluster template along with the associated overlays.
So changes in yaml deploying actual CAPI components such as this PR are not captured, unfortunately.

@pydctw
Copy link
Member

pydctw commented Oct 30, 2021

You can click the failed check(s), and click "rerun all jobs" on the top right. Are you seeing the option? I just reran the failed checks, and it does look like this change may be responsible for some integration/e2e tests failing

I don't see "rerun all jobs" option. This is the first time I am reviewing PRs in tanzu-framework so trying to get familiarized with different label/commands.

Thanks for the explanation on the clustergen.diff file. Makes sense.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the value of CABPK --bootstrap-token-ttl to account for etcd replication time in vSphere clusters
5 participants