This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Tweaks ContextAwareDiscovery to allow more generic feature flags to u… #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalner-vmware
added
kind/cleanup
anujc25
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
LGTM. Thanks, @swalner-vmware for making this consistent with other implementations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The global feature flag context-aware-discovery gives us an opportunity to create convenience methods that can be used with other global feature flags
Describe testing done for PR
Ran tests locally
PR Checklist
Additional information
Related to #767