Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Add control-plane toleration to capabilities manager #3499

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Add control-plane toleration to capabilities manager #3499

merged 1 commit into from
Oct 17, 2022

Conversation

seemiller
Copy link
Contributor

What this PR does / why we need it

There is a long running effort to rename node-role.kubernetes.io/master to node-role.kubernetes.io/control-plane. This PR adds the node-role.kubernetes.io/control-plane toleration to capabilities manager.

A future PR will issued to remove the offensive node-role.kubernetes.io/master toleration.

Describe testing done for PR

Ran the task make test in the capabilities directory.

Release note

Add the `node-role.kubernetes.io/control-plane` toleration to capabilities manager.

Additional information

Special notes for your reviewer

Copy link
Contributor

@codegold79 codegold79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seemiller seemiller added the ok-to-merge PRs should be labelled with this before merging label Sep 27, 2022
@seemiller
Copy link
Contributor Author

/test multi-versions-install-aws

@alfredthenarwhal
Copy link
Collaborator

Tests failed! Build no: 2818

@seemiller
Copy link
Contributor Author

/test install-aws

@alfredthenarwhal
Copy link
Collaborator

Tests failed! Build no: 2819

@seemiller
Copy link
Contributor Author

/test install-aws

2 similar comments
@navidshaikh
Copy link
Contributor

/test install-aws

@navidshaikh
Copy link
Contributor

/test install-aws

@alfredthenarwhal
Copy link
Collaborator

Tests canceled! Build no: 2891

@seemiller
Copy link
Contributor Author

/test install-vc7

@seemiller
Copy link
Contributor Author

/test upgrade-vc7

@alfredthenarwhal
Copy link
Collaborator

Build failed! Build no: 2892

@alfredthenarwhal
Copy link
Collaborator

Build failed! Build no: 2894

@alfredthenarwhal
Copy link
Collaborator

Build failed! Build no: 2895

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #3499 (20264e5) into main (83f9375) will decrease coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
- Coverage   46.31%   45.39%   -0.93%     
==========================================
  Files         400      425      +25     
  Lines       39583    41147    +1564     
==========================================
+ Hits        18334    18677     +343     
- Misses      19563    20762    +1199     
- Partials     1686     1708      +22     
Impacted Files Coverage Δ
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.85% <0.00%> (-1.02%) ⬇️
cmd/cli/plugin/cluster/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/kubeconfig_get.go 8.82% <0.00%> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/upgrade.go 57.55% <0.00%> (ø)
.../cli/plugin/cluster/set_machinehealthcheck_node.go 23.33% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@danniel1205 danniel1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the PR

@seemiller seemiller merged commit e916c4f into vmware-tanzu:main Oct 17, 2022
@seemiller seemiller deleted the capabilities-controller-toleration branch October 17, 2022 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants