-
Notifications
You must be signed in to change notification settings - Fork 192
Add control-plane toleration to capabilities manager #3499
Add control-plane toleration to capabilities manager #3499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/test multi-versions-install-aws |
Tests failed! Build no: 2818 |
/test install-aws |
Tests failed! Build no: 2819 |
/test install-aws |
2 similar comments
/test install-aws |
/test install-aws |
Tests canceled! Build no: 2891 |
/test install-vc7 |
/test upgrade-vc7 |
Build failed! Build no: 2892 |
Build failed! Build no: 2894 |
Build failed! Build no: 2895 |
Codecov Report
@@ Coverage Diff @@
## main #3499 +/- ##
==========================================
- Coverage 46.31% 45.39% -0.93%
==========================================
Files 400 425 +25
Lines 39583 41147 +1564
==========================================
+ Hits 18334 18677 +343
- Misses 19563 20762 +1199
- Partials 1686 1708 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the PR
What this PR does / why we need it
There is a long running effort to rename
node-role.kubernetes.io/master
tonode-role.kubernetes.io/control-plane
. This PR adds thenode-role.kubernetes.io/control-plane
toleration to capabilities manager.A future PR will issued to remove the offensive
node-role.kubernetes.io/master
toleration.Describe testing done for PR
Ran the task
make test
in the capabilities directory.Release note
Additional information
Special notes for your reviewer