Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Addons controller support for cluster api v1beta1 #654

Closed
1 of 9 tasks
Tracked by #936
shyaamsn opened this issue Sep 19, 2021 · 3 comments
Closed
1 of 9 tasks
Tracked by #936

Addons controller support for cluster api v1beta1 #654

shyaamsn opened this issue Sep 19, 2021 · 3 comments
Assignees
Labels
area/addons kind/feature Categorizes issue or PR as related to a new feature priority/critical-urgent
Milestone

Comments

@shyaamsn
Copy link
Contributor

shyaamsn commented Sep 19, 2021

(This is used to request new product features)

Describe the feature request
Addons controller support for cluster api v1beta1. Cluster api v1beta1 support k8s1.22. In order to support k8s1.22 addons controller has to support cluster api v1beta1

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

  • APIs
  • Addons
  • CLI
  • Docs
  • Installation
  • Plugin
  • Security
  • Test and Release
  • User Experience

Additional context

@shyaamsn shyaamsn added kind/enhancement Categorizes issue or PR as related to an enhancement priority/critical-urgent area/addons labels Sep 19, 2021
@vijaykatam
Copy link
Contributor

Did investigation for migration addons controller to v1alpha4

  1. cert-manager to 1.5.3
  2. controller-runtime bump to 0.9.0+
  3. controller-tools bump to v0.6+
  4. go.mod sigs.k8s.io/cluster-api => sigs.k8s.io/cluster-api v0.4.x (align with parent go.mod)
  5. Rename --metrics-addr to --metrics-bind-addr
  6. Rename --leader-election to --leader-elect

Upgrade workflow:

  1. Manually upgraded capi and cert-manager components on 1.4 cluster
  2. capi upgrades all cluster-api types to v1alphav4
  3. Current version of addons manager watching for v1alphav3 continues to work because of conversion webhooks in capi.
  4. Post upgrade, addons manager should watch for v1alphav4 and that will work normally.

@shyaamsn shyaamsn added kind/feature Categorizes issue or PR as related to a new feature and removed kind/enhancement Categorizes issue or PR as related to an enhancement labels Sep 30, 2021
@danniel1205 danniel1205 changed the title Addons controller support for cluster api v1alpha4 Addons controller support for cluster api v1beta1 Oct 7, 2021
@danniel1205
Copy link
Contributor

The analysis from #654 (comment) was for v1alpha4. We need to bump the dependencies version to support v1beta1.

@danniel1205
Copy link
Contributor

changes are merged as part of #927

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/addons kind/feature Categorizes issue or PR as related to a new feature priority/critical-urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants