Use created namespace name during run --wait
#930
Conversation
zubron
force-pushed
the
use-created-namespace-929
branch
from
197dbe0 to
0b0365e
Compare
When using a manifest from a file and the `--wait` flag with `run`, a segfault would happen because the value is retrieved from the `config.Config` which is part of the `GenConfig` within the `RunConfig`. When using a file, this config is nil, so an attempt to retrieve the namespace value resulted in a segfault. Instead, we can capture the namespace from the objects within the manifest file when they are being created by the Kubernetes client. Signed-off-by: Bridget McErlean <[email protected]>
zubron
force-pushed
the
use-created-namespace-929
branch
from
0b0365e to
e1f48c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
==========================================
- Coverage 47.59% 47.56% -0.03%
==========================================
Files 76 76
Lines 5175 5178 +3
==========================================
Hits 2463 2463
- Misses 2562 2565 +3
Partials 150 150
Continue to review full report at Codecov.
|
| // It may not be available within the RunConfig but we can retrieve it from the | ||
| // namespace of objects within the manifest. | ||
| if createdNamespace == "" && namespace != "" { | ||
| createdNamespace = namespace |
There was a problem hiding this comment.
Why not just use namespace? I'm not clear on what createdNamespace adds since by default it is the empty string, and it is set to namespace if it isn't the empty string. So won't it just always match namespace?
There was a problem hiding this comment.
This loop is iterating over all the resources in the yaml output. Some of those are cluster-scoped (e.g. ClusterRole) which means that they do not have an associated namespace. If the yaml was edited to have these resources be the last ones to be iterated over, namespace would be empty at the end of the loop. You can see this in the logs from Sonobuoy run, some of the resources it logs don't have the namespace field set in the log. Storing the first non empty namespace was an attempt to combat that. This approach isn't fool proof, but seemed good enough for now as it avoids the need to fully parse the yaml and find the Namespace resource, or the contents of the config map (we do this in gen_test).
What this PR does / why we need it:
When using a manifest from a file and the
--waitflag withrun, asegfault would happen because the value is retrieved from the
config.Configwhich is part of theGenConfigwithin theRunConfig.When using a file, this config is nil, so an attempt to retrieve the
namespace value resulted in a segfault. Instead, we can capture the
namespace from the objects within the manifest file when they are being
created by the Kubernetes client.
Signed-off-by: Bridget McErlean [email protected]
Which issue(s) this PR fixes
run --waitwhen reading manifest from stdin/file #929Special notes for your reviewer:
I've written added an integration level test to check this and confirmed that the segfault exists before the change and is fixed by it.
Release note: