Add image building/pushing back to Travis #835
Conversation
| - ./travis-ci.sh | ||
|
|
||
| script: | ||
| - VERBOSE=true make test int |
There was a problem hiding this comment.
Most of these changes are due to the fact that the travis cli tool edits/rewrites the .travis.yml file. So it is probably just a serialization improvement even if both are technically valid.
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
========================================
Coverage ? 46.9%
========================================
Files ? 75
Lines ? 4667
Branches ? 0
========================================
Hits ? 2189
Misses ? 2348
Partials ? 130Continue to review full report at Codecov.
|
|
So this is a 👍 to moving to CI at some point I think: He ended up creating an issue here: travis-ci/travis-ci#6652 We'll need to adjust this script to deal with fact that the |
Got authorization to re-add credentials for image pushing to Travis via their recommended approach outlined here: https://docs.travis-ci.com/user/encrypting-files/ Fixes #808 Signed-off-by: John Schnake <[email protected]>
|
|
||
| script: | ||
| - export BRANCH=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then echo $TRAVIS_BRANCH; else echo $TRAVIS_PULL_REQUEST_BRANCH; fi) | ||
| - echo "TRAVIS_BRANCH=$TRAVIS_BRANCH, PR=$TRAVIS_PULL_REQUEST, BRANCH=$BRANCH" |
There was a problem hiding this comment.
Added these 2 for clarity; very unintuitive how $TRAVIS_BRANCH won't be the PRs branch. See the issues/article I linked to elsewhere on this PR.
| function gcr_push() { | ||
| openssl aes-256-cbc -K $encrypted_222a2009ef6d_key -iv $encrypted_222a2009ef6d_iv -in heptio-images-c14f11347d8b.json.enc -out heptio-images-c14f11347d8b.json -d | ||
| gcloud auth activate-service-account --key-file heptio-images-c14f11347d8b.json | ||
| # https://github.com/travis-ci/travis-ci/issues/9905 |
There was a problem hiding this comment.
This issue was closed. Do we still need to do the unset below?
There was a problem hiding this comment.
/shrug
I was just adding back the exact code that we previously had done this work. Let's just leave it (if it works) since this is all probably temporary anyways.
There was a problem hiding this comment.
this is all probably temporary anyways
That is a very good point. Ignore that comment then :)
What this PR does / why we need it:
Got authorization to re-add credentials for image pushing to
Travis via their recommended approach outlined here:
https://docs.travis-ci.com/user/encrypting-files/
Which issue(s) this PR fixes
Fixes #808
Special notes for your reviewer:
Release note: