Updates to use dep against 1.8/5.0.0 client #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy St. Clair <[email protected]>
|
@ncdc could you verify the .toml is sane according to api-machinery version(s)? /cc @davecheney |
timothysc
changed the title
|
@timothysc will do, although it might have to wait until tomorrow morning. Also, did you run |
timothysc
force-pushed
the
dep_release-5
branch
2 times, most recently
from
c0c07a8
to
1a2988c
Compare
|
@ncdc just did, and it cut the deps to 1/4 the original size. Thx! |
|
Timeline is crunched a bit, I'm going to merge but if you spot something please let us know. |
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Updates to use dep against 1.8/5.0.0 client Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Updates to use dep against 1.8/5.0.0 client Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timothy St. Clair [email protected]
Partially addresses #17 but also rev's to latest client in prep for 0.9.0 release. I'll look at the tests for sanity.