Switch to upstream Go build images. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These internal `gcr.io/heptio-images/golang` images are deprecated. It looks like `bash` was the only thing that the Sonobuoy runtime image needed that wasn't in the upstream `golang:1.9-alpine3.6` image. Signed-off-by: Matt Moyer <[email protected]>
chuckha
approved these changes
Apr 24, 2018
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
These internal `gcr.io/heptio-images/golang` images are deprecated. It looks like `bash` was the only thing that the Sonobuoy runtime image needed that wasn't in the upstream `golang:1.9-alpine3.6` image. Signed-off-by: Matt Moyer <[email protected]> Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
These internal `gcr.io/heptio-images/golang` images are deprecated. It looks like `bash` was the only thing that the Sonobuoy runtime image needed that wasn't in the upstream `golang:1.9-alpine3.6` image. Signed-off-by: Matt Moyer <[email protected]> Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
ceridwen
pushed a commit
to ceridwen/sonobuoy
that referenced
this pull request
Jul 19, 2018
These internal `gcr.io/heptio-images/golang` images are deprecated. It looks like `bash` was the only thing that the Sonobuoy runtime image needed that wasn't in the upstream `golang:1.9-alpine3.6` image. Signed-off-by: Matt Moyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the Docker base images used for building and running Sonobuoy. It switches away from internal
gcr.io/heptio-images/golangimages to the upstreamgolangimage.These internal
gcr.io/heptio-images/golangimages are deprecated. It looks likebashwas the only thing that the Sonobuoy runtime image needed that wasn't in the upstreamgolang:1.9-alpine3.6image.