Rename pkg/tarball/test_data to pkg/tarball/testdata #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzdan
force-pushed
the
jazzdan/rename_test_data_to_testdata
branch
from
f794f77
to
62d37b5
Compare
|
/assign @chuckha |
chuckha
approved these changes
Apr 19, 2018
There was a problem hiding this comment.
This has been on my to-do list for a while. Thanks for the fix.
https://dave.cheney.net/2016/05/10/test-fixtures-in-go
〰️ 🐢 😨
|
oh @jazzdan this needs a rebase whenever you get a chance. |
Signed-off-by: Dan Miller <[email protected]>
jazzdan
force-pushed
the
jazzdan/rename_test_data_to_testdata
branch
from
62d37b5
to
4d87494
Compare
|
@chuckha rebased |
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Signed-off-by: Dan Miller <[email protected]> Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Signed-off-by: Dan Miller <[email protected]> Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
ceridwen
pushed a commit
to ceridwen/sonobuoy
that referenced
this pull request
Jul 19, 2018
Signed-off-by: Dan Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Miller [email protected]
What this PR does / why we need it:
Certain tools expect fixtures to be in a directory called
testdata. It also is more consistent with other code bases, such as the standard library.