Add CIS Benchmark plugin blog post #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Rosland <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
=========================================
- Coverage 48.39% 48.29% -0.1%
=========================================
Files 76 76
Lines 5377 5377
=========================================
- Hits 2602 2597 -5
- Misses 2619 2622 +3
- Partials 156 158 +2
Continue to review full report at Codecov.
|
johnSchnake
approved these changes
Nov 18, 2019
zubron
reviewed
Nov 18, 2019
| $ sonobuoy gen plugin \ | ||
| --name kube-bench-worker \ | ||
| --image=schnake/kube-bench:v0.2.0-demo \ | ||
| --cmd=/bin/sh |
There was a problem hiding this comment.
Suggested change
| --cmd=/bin/sh | |
| --cmd=/bin/sh \ |
| --name kube-bench-worker \ | ||
| --image=schnake/kube-bench:v0.2.0-demo \ | ||
| --cmd=/bin/sh | ||
| --args=-c |
There was a problem hiding this comment.
Suggested change
| --args=-c | |
| --arg=-c \ |
| --image=schnake/kube-bench:v0.2.0-demo \ | ||
| --cmd=/bin/sh | ||
| --args=-c | ||
| --args=”kube-bench --version 1.13 --outputfile /tmp/results/output.xml --junit ; echo -n /tmp/results/output.xml > /tmp/results/done” \ |
There was a problem hiding this comment.
Suggested change
| --args=”kube-bench --version 1.13 --outputfile /tmp/results/output.xml --junit ; echo -n /tmp/results/output.xml > /tmp/results/done” \ | |
| --arg="kube-bench --version 1.13 --outputfile /tmp/results/output.xml --junit ; echo -n /tmp/results/output.xml > /tmp/results/done" \ |
| Each of these things can be done manually, or with the following command: | ||
|
|
||
| ``` | ||
| $ cat kub-bench-worker.yaml | \ |
There was a problem hiding this comment.
Suggested change
| $ cat kub-bench-worker.yaml | \ | |
| $ cat kube-bench-worker.yaml | \ |
|
|
||
| ``` | ||
| $ cat kub-bench-worker.yaml | \ | ||
| sed ‘/kube-bench-worker/kube-bench-master/’ | \ |
There was a problem hiding this comment.
Hmm, I tried this out but these sed commands don't work for me. I think they should be:
Suggested change
| sed ‘/kube-bench-worker/kube-bench-master/’ | \ | |
| sed 's/kube-bench-worker/kube-bench-master/g' | \ |
| ``` | ||
| $ cat kub-bench-worker.yaml | \ | ||
| sed ‘/kube-bench-worker/kube-bench-master/’ | \ | ||
| sed ‘/- kube-bench/- kube-bench master/’ | \ |
There was a problem hiding this comment.
Suggested change
| sed ‘/- kube-bench/- kube-bench master/’ | \ | |
| sed 's/- kube-bench/- kube-bench master/g' | \ |
| $ cat kub-bench-worker.yaml | \ | ||
| sed ‘/kube-bench-worker/kube-bench-master/’ | \ | ||
| sed ‘/- kube-bench/- kube-bench master/’ | \ | ||
| sed ‘/Exists/DoesNotExist/’ > kube-bench-master.yaml |
There was a problem hiding this comment.
Suggested change
| sed ‘/Exists/DoesNotExist/’ > kube-bench-master.yaml | |
| sed 's/Exists/DoesNotExist/g' > kube-bench-master.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the CIS Benchmark plugin blog post.
Signed-off-by: Jonas Rosland [email protected]