Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a subnetport ID issue during checking the port state +1 #689

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

heypnus
Copy link
Contributor

@heypnus heypnus commented Aug 14, 2024

We changed the subnetport ID to <pod/vm name>-<uid> but when getting the NSX port state, the operator still tried to get the resource via object uid. This patch will fix the issue.

(cherry picked from commit d5423b1)

@zhengxiexie
Copy link
Contributor

/e2e

2 similar comments
@heypnus
Copy link
Contributor Author

heypnus commented Aug 14, 2024

/e2e

@heypnus
Copy link
Contributor Author

heypnus commented Aug 14, 2024

/e2e

dantingl
dantingl previously approved these changes Aug 14, 2024
@heypnus heypnus changed the title Fix a subnetport ID issue during checking the port state Fix a subnetport ID issue during checking the port state +1 Aug 14, 2024
We changed the subnetport ID to `<pod/vm name>-<uid>` but when getting
the NSX port state, the operator still tried to get the resource via
object uid. This patch will fix the issue.

(cherry picked from commit d5423b1)
Copy link
Contributor

@wenqiq wenqiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, The e2e is passed in the main branch?

@dantingl dantingl merged commit 35f52b8 into vmware-tanzu:v4.2.0 Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants