Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s deps to v1.28, kapp-ctrl to v0.49 and flux2 to >=v2.0.0 #7219

Merged
merged 21 commits into from
Jan 9, 2024

Conversation

antgamdia
Copy link
Contributor

@antgamdia antgamdia commented Dec 20, 2023

Description of the change

This PR is bumping up some dependencies together, as they are somehow coupled. Besides, it performs some changes on the Flux resources (including the changes performed in #7132 from @kvaps; thank you for the PR!) to make it compatible with their v2.0.0 release onwards.

As pointed out in #7132 (comment), some additional changes were required, namely:

  • Effectively use latest Flux version in CI, for identifying the issue.
  • Replace PollInfinite with PollUntilContextCancel bc of a k8s deprecation.
  • Rename fluxcd imports to sourcev1beta2 to clearly identify which version we are using.
  • Add TODOs for using CertSecretRef in the future (upcoming deprecation, but it will be addressed in a separate PR).
  • Minor change in method signature because of the kapp-ctrl upgrade.

Benefits

We'll be able again to get dependabot's upgrades in these dependencies and, more importantly, Kubeapps will work again with latest FluxCD releases.

Possible drawbacks

Conversely, Kubeapps will likely fail with Flux2 version prior to 2.0.0. See more information and migration guide at: https://github.com/fluxcd/flux2/releases/tag/v2.0.0

Applicable issues

Additional information

N/A

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for kubeapps-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f1f108
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/659d26c1e66ded000894d339
😎 Deploy Preview https://deploy-preview-7219--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antgamdia antgamdia mentioned this pull request Dec 22, 2023
@antgamdia antgamdia added the dependencies Pull requests that update a dependency file label Dec 22, 2023
@antgamdia antgamdia changed the title Update go deps Bump k8s deps to v1.28, kapp-ctrl to v0.49 and flux2 to >=v2.0.0 Jan 9, 2024
@antgamdia antgamdia changed the title Bump k8s deps to v1.28, kapp-ctrl to v0.49 and flux2 to >=v2.0.0 Bump k8s deps to v1.28, kapp-ctrl to v0.49 and flux2 to >=v2.0.0 Jan 9, 2024
@antgamdia
Copy link
Contributor Author

After an IRL test, it seems the catalog is now fetched properly:

image

@antgamdia antgamdia marked this pull request as ready for review January 9, 2024 11:40
@antgamdia antgamdia merged commit 2320384 into vmware-tanzu:main Jan 9, 2024
39 checks passed
@antgamdia antgamdia deleted the updateGoDeps branch January 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty catalog using fluxcd
2 participants