Refactor some names to avoid confusion between OCI repositories and Helm repositories. #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…elm repositories. Signed-off-by: Michael Nelson <[email protected]>
absoludity
force-pushed
the
6363-sync-via-oci-catalog
branch
from
66591cb
to
2dc3d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The code currently talks about OCI repositories and Helm repositories and Helm repositories that are OCI registries. This PR is just splitting out some renaming to avoid the confusion, so instead we have:
Repomodel ->AppRepositorywhich correspond to ourAppRepositorycustom resource which can represent a Helm repository or an OCI registry (or a namespace within an OCI registry) which contains many oci repositories.Repointerace ->ChartCataloginterface, as this is implemented by both Helm and OCI versionsIt contains another small refactor pulling out a
ocicatalog_client.NewClienthelper.Leaving as draft for now in case I come across any other straight renames/refactors in the current work.
Applicable issues
Additional information