Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cache used by pinniped proxy to include the k8s api server url. #5913

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

absoludity
Copy link
Contributor

Signed-off-by: Michael Nelson [email protected]

Description of the change

Fixes #5912 by including the k8s server url in the cache key.

Benefits

Fixes an issue that was causing logouts when switching clusters.

Possible drawbacks

Applicable issues

Additional information

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for kubeapps-dev ready!

Name Link
🔨 Latest commit c1c651c
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63d08b4c42e6e20008936b5d
😎 Deploy Preview https://deploy-preview-5913--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@absoludity
Copy link
Contributor Author

Verified locally that this fixes one of the errors when authenticating with another cluster.

@absoludity absoludity merged commit 2269c74 into main Jan 25, 2023
@absoludity absoludity deleted the 5912-ppcache branch January 25, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinniped Proxy is caching TokenCredentialRequests across clusters
2 participants