Finish switching from GKE_BRANCH to GKE_VERSION (from #5730) #5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates Hugo version (based on instructions in the release-process.md. Signed-off-by: Michael Nelson <[email protected]>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dlaloue-vmware
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the failing full integration pipeline (which we need to pass for release).
Also updates Hugo version (based on instructions in the release-process.md.
Signed-off-by: Michael Nelson [email protected]
Description of the change
Recent runs (from the past 6 days) of the full integration pipeline have been failing. Looking for the differences, I could see that:
chart-museum.shwas failing to upload our custom apache chart to the chartmuseum instance, because...LOAD_BALANCER_IPwas set to172.18.0.2, which is theDEX_IP, whereas it should be set to the load balancer IP address (which has been created correctly), as it is in the last passing run. It's not doing this because...LOAD_BALANCER_IPaddress does so conditionally based on theGKE_BRANCHenvironment variable, which is blank... so as far as that script can tell, it's not a GKE run. The reason that theGKE_BRANCHenv var is blank is because...GKE_BRANCHenv var was removed and replaced withGKE_VERSIONeverywhere excepte2e-test.shit seems. I assume this was just an oversight on our part.So this PR just finishes that change by renaming the var in
e2e-test.sh.Benefits
Hopefully we can now pass the full integration pipeline.
Possible drawbacks
Applicable issues
Additional information