Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flux e2e test group in GHA's local_e2e_tests job #5656

Merged
merged 15 commits into from
Nov 18, 2022

Conversation

gfichtenholt
Copy link
Contributor

Description of the change

It seems that at some point, a new flux test group has been added to the /script/e2e_test.sh file, but we have forgotten to add it to the GHA's local_e2e_tests job, so this test group is not being run in the GHA workflow.

I have also took advantage of this PR to simplify the local_e2e_tests GHA job by setting a timeout of 6 minutes for every tests group, instead of having a default of 4 and setting it to 6 for the operator's group to avoid flaky tests.
Benefits

Run all the e2e tests from GHA.

Possible drawbacks

N/A

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5350bd3
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/637763f00036b10009e64496

@gfichtenholt gfichtenholt self-assigned this Nov 17, 2022
@gfichtenholt gfichtenholt added component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code labels Nov 17, 2022
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg.

Comment on lines -615 to +607
SRP_CLI_VERSION: ${{env.SRP_CLI_VERSION}}
SRP_CLI_VERSION: ${SRP_CLI_VERSION}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an unintentional change - but should go away if you merge main? (I saw @beni0888 fix this in main earlier today - adding the line that your PR is reverting here by accident).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, don't worry about it. I am in a testing phase

@gfichtenholt gfichtenholt marked this pull request as draft November 17, 2022 07:07
@gfichtenholt
Copy link
Contributor Author

gfichtenholt commented Nov 17, 2022

latest debug info:
flux's source-controller deployment fails during installation after a number of retries due to

+ kubectl describe deployment --namespace flux-system source-controller
Name:               source-controller
...
Conditions:
  Type           Status  Reason
  ----           ------  ------
  Available      False   MinimumReplicasUnavailable
  Progressing    False   ProgressDeadlineExceeded
OldReplicaSets:  <none>
NewReplicaSet:   source-controller-57ff555bd (1/1 replicas created)
Events:
  Type    Reason             Age   From                   Message
  ----    ------             ----  ----                   -------
  Normal  ScalingReplicaSet  10m   deployment-controller  Scaled up replica set source-controller-57ff555bd to 1

describe pod shows

+ kubectl describe pod source-controller-57ff555bd-xktgf --namespace flux-system
Name:           source-controller-57ff555bd-xktgf
Namespace:      flux-system
Priority:       0
Node:           <none>
Labels:         app=source-controller
                pod-template-hash=57ff555bd
Annotations:    container.seccomp.security.alpha.kubernetes.io/manager: runtime/default
                prometheus.io/port: 8080
                prometheus.io/scrape: true
Status:         Pending
IP:             
IPs:            <none>
Controlled By:  ReplicaSet/source-controller-57ff555bd
Containers:
  manager:
    Image:       ghcr.io/fluxcd/source-controller:v0.31.0
    Ports:       9090/TCP, 8080/TCP, 9440/TCP
    Host Ports:  0/TCP, 0/TCP, 0/TCP
    Args:
      --events-addr=http://notification-controller.flux-system.svc.cluster.local./
      --watch-all-namespaces
      --log-level=info
      --log-encoding=json
      --enable-leader-election
      --storage-path=/data
      --storage-adv-addr=source-controller.$(RUNTIME_NAMESPACE).svc.cluster.local.
    Limits:
      cpu:     1
      memory:  1Gi
    Requests:
      cpu:      50m
      memory:   64Mi
    Liveness:   http-get http://:healthz/healthz delay=0s timeout=1s period=10s #success=1 #failure=3
    Readiness:  http-get http://:http/ delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment:
      RUNTIME_NAMESPACE:  flux-system (v1:metadata.namespace)
      TUF_ROOT:           /tmp/.sigstore
    Mounts:
      /data from data (rw)
      /tmp from tmp (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-wz7zq (ro)
Conditions:
  Type           Status
  PodScheduled   False 
Volumes:
  data:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:     
    SizeLimit:  <unset>
  tmp:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:     
    SizeLimit:  <unset>
  kube-api-access-wz7zq:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason            Age               From               Message
  ----     ------            ----              ----               -------
  Warning  FailedScheduling  19s (x7 over 6m)  default-scheduler  0/1 nodes are available: 1 Insufficient cpu.

@gfichtenholt gfichtenholt marked this pull request as ready for review November 18, 2022 10:05
@gfichtenholt gfichtenholt merged commit e3a6b73 into vmware-tanzu:main Nov 18, 2022
@gfichtenholt gfichtenholt deleted the run-flux-e2e-tests-gha branch November 18, 2022 16:24
gfichtenholt added a commit that referenced this pull request Nov 18, 2022
…n my previous PR (#5668)

Undoing a small change unintentionally made to one file in
#5656
@beni0888
Copy link
Collaborator

Great work @gfichtenholt !! 👏🏻 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants