-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run flux e2e test group in GHA's local_e2e_tests job #5656
Run flux e2e test group in GHA's local_e2e_tests job #5656
Conversation
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Greg.
SRP_CLI_VERSION: ${{env.SRP_CLI_VERSION}} | ||
SRP_CLI_VERSION: ${SRP_CLI_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an unintentional change - but should go away if you merge main? (I saw @beni0888 fix this in main earlier today - adding the line that your PR is reverting here by accident).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, don't worry about it. I am in a testing phase
latest debug info:
describe pod shows
|
Great work @gfichtenholt !! 👏🏻 👏🏻 |
Description of the change
It seems that at some point, a new flux test group has been added to the /script/e2e_test.sh file, but we have forgotten to add it to the GHA's local_e2e_tests job, so this test group is not being run in the GHA workflow.
I have also took advantage of this PR to simplify the local_e2e_tests GHA job by setting a timeout of 6 minutes for every tests group, instead of having a default of 4 and setting it to 6 for the operator's group to avoid flaky tests.
Benefits
Possible drawbacks
N/A