Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status badges for GHA's workflows #5620

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Add status badges for GHA's workflows #5620

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b48d41
Add status badges for GHA's workflows
Nov 8, 2022
004f540
Remove release pipeline badge and add the full integration one
Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# <img src="site/content/docs/latest/img/logo.svg" width="40" align="left"/> Kubeapps

[![CircleCI](https://circleci.com/gh/vmware-tanzu/kubeapps/tree/main.svg?style=svg)](https://circleci.com/gh/vmware-tanzu/kubeapps/tree/main)
[![Main Pipeline](https://github.com/vmware-tanzu/kubeapps/actions/workflows/kubeapps-main.yaml/badge.svg)](https://github.com/vmware-tanzu/kubeapps/actions/workflows/kubeapps-main.yaml)
[![Release Pipeline](https://github.com/vmware-tanzu/kubeapps/actions/workflows/kubeapps-release.yml/badge.svg)](https://github.com/vmware-tanzu/kubeapps/actions/workflows/kubeapps-release.yml)
[![CodeQL](https://github.com/vmware-tanzu/kubeapps/actions/workflows/codeql-scheduled.yml/badge.svg)](https://github.com/vmware-tanzu/kubeapps/actions/workflows/codeql-scheduled.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we really need these two ones. I mean, given that the release is outsourced to Bitnami, does really make sense for us to show the status here?
Regarding the CodeQL, well... it's ok, but, what's really the point (for any user coming to the project, not for us, I mean)

Anyway, +1ing, we can always change it back :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm... To be honest, I'm not sure either 😅 As I see it, CodeQL will reflect current compliance WRT the CodeQL analyzer, which could be interesting for people coming to the project and even for us, the maintainers, ourselves. And regarding the release workflow, even though the release is delegated to Bitnami, the release process is triggered by kubeapps and has an associated workflow... I think the key question here is, what is the target audience of these badges? Are they the maintainers/contributors, or the adopters? In case the answer is the latter, it probably doesn't make much sense to add those badges.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that, we commented that would be interesting to add a new workflow in charge of running the Full Integration Workflow on schedule. Do you think it would be useful to add its badge to the README.md file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antgamdia Taking into account that we already have the Full Integration Pipeline and to run it on schedule we don't need to create a new workflow, but just add a new on.schedule event condition, I've added a badge for it and remove the one for the Release Pipeline because, as you pointed out, it maybe doesn't add much value. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great! Makes sense. Let's keep all the badges for now, at least, it's great to see everything green :P

[![Netlify Status](https://api.netlify.com/api/v1/badges/7e0e2833-1d75-43f6-b006-632d359bb83b/deploy-status)](https://app.netlify.com/sites/kubeapps-dev/deploys)

## Overview
Expand Down