Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting pending pkgs #5565

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

As reported in #5538, sometimes, packages get stuck in a pending state. Currently, Kubeapps UI was preventing the deletion of pending packages, but this might not be a good solution if we really want to delete a package.
It should be the backend that manages the deletion (or not) of a pending package.

However, the tooltip is still being shown, this way users, at least, will notice something is happening with this package.

Benefits

No more pending packages stuck

Possible drawbacks

N/A

Applicable issues

Additional information

image

image

Signed-off-by: Antonio Gamez Diaz <[email protected]>
@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit fe3a714
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/6357d58de5f4ff0009994503

Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antgamdia antgamdia merged commit fbf0791 into vmware-tanzu:main Oct 26, 2022
@antgamdia antgamdia deleted the 5538-deletePendingPkgs branch October 26, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete Flux package in "pending" state
3 participants