Repos global list on additional clusters #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2022 10:21
Signed-off-by: Rafa Castelblanque <[email protected]>
Signed-off-by: Rafa Castelblanque <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.
|
castelblanque
commented
Oct 17, 2022
| @@ -172,6 +196,7 @@ function PkgRepoList() { | |||
| namespace={currentNamespace} | |||
| helmGlobalNamespace={helmGlobalNamespace} | |||
| carvelGlobalNamespace={carvelGlobalNamespace} | |||
| disabled={!supportedCluster} | |||
There was a problem hiding this comment.
Also disabled the "Add package repository" button if the cluster is not the default one.
antgamdia
approved these changes
Oct 17, 2022
Do you mean adding a button like that close the current "Add package repository" (top right)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque [email protected]
Description of the change
This PR adds the list of global repos when context is set to a cluster other than the default one.
List is set on read only mode.
Same UI warning message is kept, as it still describes correctly the situation.
Targeted at the case stated in #2717, users that do not have access to the main/default cluster where Kubeapps is installed.
Benefits
Possible drawbacks
N/A
Applicable issues