Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux oci support 7: unit tests for OCI support in flux plugin #5178

Merged
merged 13 commits into from
Aug 9, 2022

Conversation

gfichtenholt
Copy link
Contributor

@gfichtenholt gfichtenholt commented Aug 8, 2022

This PR is mostly about adding unit tests for OCI support in flux plugin. The unit tests allow me to test the repo and chart redis cache are working as expected.
Other things in this PR:

  • added stub for ShutDownWithDrain to rate_limiting_queue per Prerelease updates #5123 (comment). I will implement once we upgrade k8s.io/client-go as stated and I can test the scenario
  • cleaned up automation login in testdata/kind-cluster-setup.sh used to set up some integration scenarios
  • bumped fluxv2 version to latest
  • added OCI_TERMINOLOGY.md to try and explain different terminology used by upstream
  • renamed a few types, like OCIRegistry -> OCIChartRepository to be a little more consistent with existing terminology

All tests (integration+unit) passing.

@gfichtenholt gfichtenholt self-assigned this Aug 8, 2022
@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a9acdf7
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62f1fb63ed163d0008a9c9a9

@gfichtenholt gfichtenholt linked an issue Aug 8, 2022 that may be closed by this pull request
@gfichtenholt gfichtenholt requested a review from antgamdia August 9, 2022 02:15
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thoroughly testing the OCI support, that's great. I wish we had these test suites periodically executed as part of our CI as well.

@@ -0,0 +1,122 @@
# OCI TERMINOLOGY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and I'm really fine with this file being at this place for now, however, for leveraging the website docs rendering, we should move it eventually to site/content/docs/latest/reference/developer.

// k8s.io/client-go >= 0.23.X
// ref https://github.com/vmware-tanzu/kubeapps/pull/5123#issuecomment-1194756900
// I will implement once we upgrade k8s.io/client-go as stated and I can test the scenario
func (q *Type) ShutDownWithDrain() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's great as the PR we opened in Helm has been accepted, so it is a matter of time before we can finally bump up the version.

@gfichtenholt
Copy link
Contributor Author

Awesome! Thoroughly testing the OCI support, that's great. I wish we had these test suites periodically executed as part of our CI as well.

Sure! This can happen with a little bit of work. Just a matter of prioritizing it over other things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support for OCI registries in Flux plugin
3 participants