-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flux oci support 7: unit tests for OCI support in flux plugin #5178
Flux oci support 7: unit tests for OCI support in flux plugin #5178
Conversation
…reating a clone which contents I get to manage as I see fit
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thoroughly testing the OCI support, that's great. I wish we had these test suites periodically executed as part of our CI as well.
@@ -0,0 +1,122 @@ | |||
# OCI TERMINOLOGY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, and I'm really fine with this file being at this place for now, however, for leveraging the website docs rendering, we should move it eventually to site/content/docs/latest/reference/developer
.
// k8s.io/client-go >= 0.23.X | ||
// ref https://github.com/vmware-tanzu/kubeapps/pull/5123#issuecomment-1194756900 | ||
// I will implement once we upgrade k8s.io/client-go as stated and I can test the scenario | ||
func (q *Type) ShutDownWithDrain() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's great as the PR we opened in Helm has been accepted, so it is a matter of time before we can finally bump up the version.
Sure! This can happen with a little bit of work. Just a matter of prioritizing it over other things |
This PR is mostly about adding unit tests for OCI support in flux plugin. The unit tests allow me to test the repo and chart redis cache are working as expected.
Other things in this PR:
All tests (integration+unit) passing.