add unit tests for fluxv2 plugin GetAvailablePackages #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow adding an optional description for app repositories
absoludity
approved these changes
May 27, 2021
| ), nil | ||
| }, | ||
| statusCode: codes.OK, | ||
| }, |
There was a problem hiding this comment.
The previous two tests differ only in that one has a nil conditions, the other has an empty map? Fine either way, but normally (for me) this indicates that the function itself is perhaps dealing with too many details. So, for example, if the functionality that checks if the repo is ready was pulled out to a separate function, func isRepoReady(*unstructured.Unstructured) bool (which can be unit-tested independently), then the unit tests for this current function, GetAvailablePackages, don't need to iterate through all the permutations of those details, nor care about them.
Again, fine as is, just a thought.
There was a problem hiding this comment.
good suggestion. I will make that change. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.