Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Repository] refactor fluxv2 to use managed-by annotation instead of system flag #4871

Closed
dlaloue-vmware opened this issue Jun 8, 2022 · 0 comments · Fixed by #5714
Closed

[Repository] refactor fluxv2 to use managed-by annotation instead of system flag #4871

dlaloue-vmware opened this issue Jun 8, 2022 · 0 comments · Fixed by #5714
Assignees
@gfichtenholt
Labels
component/plugin-flux Issue related to kubeapps plugin to manage Helm charts via Flux kind/enhancement An issue that reports an enhancement for an implemented feature
Milestone
Update package re...

Comments

@dlaloue-vmware
Copy link
Collaborator

For repositories, secrets used for authentication can be either user managed or kubeapps managed.
The current mechanism is based on a system flag to enable one more or the other mode. This limits the flexibility to have some users use one way (e.g. cli) or the other (e.g. UI) in a single Kubeapps installation.

this issue is to refactor the fluxv2 plugin.
@dlaloue-vmware dlaloue-vmware added the kind/proposal An issue that reports a new feature proposal to be discussed label Jun 8, 2022
@kubeapps-bot kubeapps-bot moved this to 🗂 Backlog in Kubeapps Jun 8, 2022
@antgamdia antgamdia added this to the App repository revamping milestone Jun 8, 2022
@ppbaena ppbaena added the component/apprepository Issue related to kubeapps apprepository label Jun 8, 2022
@ppbaena ppbaena added kind/enhancement An issue that reports an enhancement for an implemented feature component/plugin-flux Issue related to kubeapps plugin to manage Helm charts via Flux and removed kind/proposal An issue that reports a new feature proposal to be discussed component/apprepository Issue related to kubeapps apprepository labels Jul 4, 2022
@antgamdia antgamdia added the next-iteration Issues to be discussed in planning session label Sep 28, 2022
@ppbaena ppbaena assigned ppbaena and gfichtenholt and unassigned ppbaena Oct 18, 2022
@ppbaena ppbaena moved this from 🗂 Backlog to 🗒 Todo in Kubeapps Oct 18, 2022
@ppbaena ppbaena removed the next-iteration Issues to be discussed in planning session label Oct 18, 2022
@gfichtenholt gfichtenholt moved this from 🗒 Todo to 🏗 In Progress in Kubeapps Nov 21, 2022
@gfichtenholt gfichtenholt linked a pull request Nov 24, 2022 that will close this issue
fix for [Repository] refactor fluxv2 to use managed-by annotation instead of system flag #4871 #5714
Merged
gfichtenholt added a commit that referenced this issue Nov 29, 2022
@gfichtenholt
fix for [Repository] refactor fluxv2 to use managed-by annotation ins…
ba97842 
…tead of system flag #4871  (#5714)

moved secret management functionality into a separate file repo_auth.go
Repository owner moved this from 🏗 In Progress to ✅ Done in Kubeapps Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfichtenholt gfichtenholt

Labels
component/plugin-flux Issue related to kubeapps plugin to manage Helm charts via Flux kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Kubeapps
Archived in project
Milestone
Update package repository API
4 participants
@ppbaena @antgamdia @dlaloue-vmware @gfichtenholt