Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[velero] Have separate resource usages for velero server pod and upgradeCRDs job pod #514

Merged
merged 4 commits into from
Nov 1, 2023
Merged

[velero] Have separate resource usages for velero server pod and upgradeCRDs job pod #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
838aab7
Have separate resource usages for velero server and upgrade job
Miraj50 Oct 31, 2023
132796a
Bumping chart version and adding comments
Miraj50 Oct 31, 2023
51bc4f0
Separate upgradeJob resources header to preserve CLI backwards compat…
Miraj50 Nov 1, 2023
1eec9f8
Fix CI error
jenting Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
check-latest: true

- name: Set up chart-testing
uses: helm/chart-testing-action@v2.4.0
uses: helm/chart-testing-action@v2.6.0

- name: Run chart-testing (list-changed)
id: list-changed
Expand Down
2 changes: 1 addition & 1 deletion charts/velero/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 1.12.1
kubeVersion: ">=1.16.0-0"
description: A Helm chart for velero
name: velero
version: 5.1.2
version: 5.1.3
home: https://github.com/vmware-tanzu/velero
icon: https://cdn-images-1.medium.com/max/1600/1*-9mb3AKnKdcL_QD3CMnthQ.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion charts/velero/templates/upgrade-crds/upgrade-crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ spec:
args:
- -c
- /velero install --crds-only --dry-run -o yaml | /tmp/kubectl apply -f -
{{- with .Values.resources }}
{{- with .Values.upgradeJobResources }}
resources:
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
9 changes: 9 additions & 0 deletions charts/velero/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ resources:
cpu: 1000m
memory: 512Mi

# Resource requests/limits to specify for the upgradeCRDs job pod.
upgradeJobResources:
requests:
cpu: 50m
memory: 64Mi
limits:
cpu: 100m
memory: 128Mi

# Configure the dnsPolicy of the Velero deployment
# See: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy
dnsPolicy: ClusterFirst
Expand Down