Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart UX improvements - schedule.template #90

Open
kav opened this issue Apr 3, 2020 · 2 comments · May be fixed by #138
Open

Chart UX improvements - schedule.template #90

kav opened this issue Apr 3, 2020 · 2 comments · May be fixed by #138
Assignees
@kav
Labels
velero

Comments

@kav
Copy link

kav commented Apr 3, 2020

Hey again,

schedules..template should be optional as you can just use the defaults. Also it's a bit non-idiomatic to use keys instead of an array with name properties here.

Let me know if you are interested in PRs for any of this.
@nrb nrb added the velero label Apr 6, 2020
@carlisia
Copy link
Contributor

Hey @kav sorry for the delay in responding. Are you available to create a PR for this and the other improvements you suggested? They could be separate PRs but also could go altogether.

kav added a commit to pelotech/vmware-tanzu-charts that referenced this issue Aug 6, 2020
@kav
Fixes vmware-tanzu#90 - schedule.template
619909b 
BREAKING CHANGE
@kav kav linked a pull request Aug 6, 2020 that will close this issue
Open
kav added a commit to pelotech/vmware-tanzu-charts that referenced this issue Aug 6, 2020
@kav
Fixes vmware-tanzu#90 - schedule.template
e75ddaf 
BREAKING CHANGE

Signed-off-by: W. Kavanaugh Latiolais <[email protected]>
@kav
Copy link
Author

kav commented Aug 18, 2020

There is an additional underlying CRD change required to make template optional but that's out of scope for the chart so I'll leave that to the team to decide on whether template is truly required for the CRD or sensible defaults can be used

kav added a commit to pelotech/vmware-tanzu-charts that referenced this issue Aug 29, 2020
@kav
Fixes vmware-tanzu#90 - schedule.template
186f673 
BREAKING CHANGE

Signed-off-by: W. Kavanaugh Latiolais <[email protected]>
kav added a commit to pelotech/vmware-tanzu-charts that referenced this issue Aug 29, 2020
@kav
Fixes vmware-tanzu#90 - schedule.template
4015a87 
BREAKING CHANGE

Signed-off-by: W. Kavanaugh Latiolais <[email protected]>
kav added a commit to pelotech/vmware-tanzu-charts that referenced this issue Aug 30, 2020
@kav
Fixes vmware-tanzu#90 - schedule.template
106c462 
BREAKING CHANGE

Signed-off-by: W. Kavanaugh Latiolais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kav kav

Labels
velero
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[velero] Chart ux improvements pelotech/vmware-tanzu-charts
4 participants
@carlisia @kav @nrb and others