Unit tests for certificate rotation #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 68.27% 69.07% +0.80%
==========================================
Files 20 20
Lines 2068 2073 +5
==========================================
+ Hits 1412 1432 +20
+ Misses 544 529 -15
Partials 112 112
|
Madhur97
force-pushed
the
cert_rotation_test
branch
2 times, most recently
from
2b1aaea to
6f52025
Compare
shivi28
reviewed
Nov 7, 2022
mayur-tolexo
reviewed
Nov 7, 2022
Madhur97
force-pushed
the
cert_rotation_test
branch
from
6f52025 to
e4bf0d3
Compare
Madhur97
force-pushed
the
cert_rotation_test
branch
from
e4bf0d3 to
05d61ea
Compare
Madhur97
force-pushed
the
cert_rotation_test
branch
from
05d61ea to
9e8dfa2
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactors the certificate rotation code to extract the logic into a separate method and adds unit tests for this method.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #656
Special notes for your reviewer