Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CAPB label in tilt-provider.json #727

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented Oct 11, 2022

What this PR does / why we need it:
Enable users to create management cluster using tilt up

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #722

Additional information
This is done as a follow up of CAPI discussion

Special notes for your reviewer

@shivi28 shivi28 changed the title Adding CABP label in tilt-provider.json [WIP] Adding CABP label in tilt-provider.json Oct 11, 2022
@shivi28 shivi28 changed the title [WIP] Adding CABP label in tilt-provider.json Adding CABP label in tilt-provider.json Oct 12, 2022
@shivi28 shivi28 changed the title Adding CABP label in tilt-provider.json Adding CAPB label in tilt-provider.json Oct 12, 2022
@mayur-tolexo
Copy link
Contributor

LGTM 👍

@mayur-tolexo
Copy link
Contributor

/approve

Copy link
Contributor

@shamsher31 shamsher31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivi28 Can you please also provide the result of the following command after adding this label?

$ tilt up

@shivi28
Copy link
Contributor Author

shivi28 commented Oct 14, 2022

@shivi28 Can you please also provide the result of the following command after adding this label?

$ tilt up

This will spin up the Management cluster successfully, but if we don't have this label then the error is captured in this issue.

@shivi28 shivi28 requested a review from shamsher31 October 17, 2022 06:50
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shivi28 shivi28 merged commit 1c7c13a into vmware-tanzu:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to intialise management cluster using tilt up
5 participants