Enable manual csr flow via clusterctl #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhur97
force-pushed
the
manual_csr_approval
branch
from
c700bb5 to
fed85cb
Compare
Madhur97
changed the title
Madhur97
force-pushed
the
manual_csr_approval
branch
from
fed85cb to
23dbc13
Compare
Madhur97
force-pushed
the
manual_csr_approval
branch
7 times, most recently
from
1b60708 to
e722c66
Compare
Madhur97
changed the title
Madhur97
force-pushed
the
manual_csr_approval
branch
from
e722c66 to
ba53658
Compare
Madhur97
changed the title
Madhur97
force-pushed
the
manual_csr_approval
branch
from
ba53658 to
c066834
Compare
anusha94
reviewed
Sep 16, 2022
shamsher31
approved these changes
Sep 19, 2022
anusha94
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables manual CSR flow via clusterctl. Now user can enable/disable manual csr approval by defining MANUAL_CSR_APPROVAL variable as enable/disable during clusterctl init. By default, it will remain disabled.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #668
Special notes for your reviewer
Have tested with MANUAL_CSR_APPROVAL as enable/disable using clusterctl.