Update kube-vip to v0.5.0 and go version to v1.18 #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhur97
force-pushed
the
kube-vip
branch
4 times, most recently
from
57f628c to
161363e
Compare
Madhur97
force-pushed
the
kube-vip
branch
12 times, most recently
from
259b637 to
a48a9a7
Compare
Madhur97
force-pushed
the
kube-vip
branch
4 times, most recently
from
a8659ef to
a85e3d1
Compare
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 68.13% 68.27% +0.14%
==========================================
Files 20 20
Lines 2068 2068
==========================================
+ Hits 1409 1412 +3
+ Misses 546 544 -2
+ Partials 113 112 -1
|
shamsher31
reviewed
Aug 25, 2022
|
@shamsher31 I think it's done due to the minimum go version requirement for kube-vip update being v1.18. |
As @sachinkumarsingh092 also added in other comment, the Go version is updated because it is needed by kubevip v0.5.0. We can update the PR title to include information about Go version update. |
Madhur97
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates kubevip to v0.5.0
Update to golang to v1.18, as it is the minimum version supported by kubevip v0.5.0
Updated golangci-lint to v1.46.2 as supported by golang v1.18
Removed a redundant statement in
installer/bundle_downloader_test.goas suggested by golangci-lint.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #670
Special notes for your reviewer