Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test for ClusterClass feature and CC docker templates #617

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented Jun 23, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #538
Fixes #539

Additional information

Special notes for your reviewer

@shivi28 shivi28 force-pushed the test_pr_cc_1 branch 7 times, most recently from 5fff532 to 471ee09 Compare June 24, 2022 07:17
@shivi28 shivi28 changed the title [DO NOT MERGE] CC test E2E test for ClusterClass feature and CC docker templates Jun 24, 2022
@shivi28 shivi28 force-pushed the test_pr_cc_1 branch 2 times, most recently from b641592 to 07a2181 Compare June 24, 2022 09:21
@shivi28 shivi28 requested a review from shamsher31 June 24, 2022 09:40
anusha94
anusha94 previously approved these changes Jun 24, 2022
Copy link
Contributor

@shamsher31 shamsher31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anusha94 anusha94 merged commit 791ea9d into vmware-tanzu:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants