Fix: Read kubeconfig first even with --bootstrap-kubeconfig flag #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
shamsher31
reviewed
Jun 29, 2022
mayur-tolexo
approved these changes
Jul 4, 2022
shamsher31
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the exisitng implementation, If the user passes the
--bootstrap-kubeconfigin repeated invocations of the agent in the same host, the code flow is to create CSR again, but the k8s APIk8s.io/client-go/util/certificate/csr.RequestCertificatetries to use the existing CSR and it will fail due to Certificate Key mismatch. With this PR,kubeconfigif existing as~/.byoh/configwill be used even with the--bootstrap-kubeconfigflag passed.Which issue(s) this PR fixes :
Fixes #598