Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host agent changes #564

Merged
merged 19 commits into from
Jun 7, 2022
Merged

Host agent changes #564

merged 19 commits into from
Jun 7, 2022

Conversation

khannakshat7
Copy link
Contributor

What this PR does / why we need it:
The host agent changes for executing install and uninstall script when --useinstallercontroller flag is set when running the host-agent binary.

Which issue(s) this PR fixes:
Fixes #563

mayur-tolexo
mayur-tolexo reviewed May 26, 2022
View reviewed changes
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/reconciler_test.go Outdated Show resolved Hide resolved
agent/reconciler/reconciler_test.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #564 (72777bb) into main (254a723) will increase coverage by 0.25%.
The diff coverage is 80.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   67.60%   67.86%   +0.25%     
==========================================
  Files          28       28              
  Lines        2380     2452      +72     
==========================================
+ Hits         1609     1664      +55     
- Misses        667      680      +13     
- Partials      104      108       +4
Impacted Files Coverage Δ
agent/main.go 19.44% <0.00%> (-0.11%) ⬇️
agent/cloudinit/cmd_runner.go 62.50% <57.14%> (-37.50%) ⬇️
agent/reconciler/host_reconciler.go 81.29% <83.33%> (-0.20%) ⬇️
agent/cloudinit/cloudinit.go 76.66% <100.00%> (ø)

dharmjit
dharmjit reviewed May 27, 2022
View reviewed changes
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

agent/main.go Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
@khannakshat7 khannakshat7 requested a review from dharmjit May 27, 2022 05:31
anusha94
anusha94 reviewed May 27, 2022
View reviewed changes
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
mayur-tolexo
mayur-tolexo reviewed May 28, 2022
View reviewed changes
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
mayur-tolexo
mayur-tolexo previously approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@mayur-tolexo mayur-tolexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@khannakshat7
Copy link
Contributor Author

@anusha94 Please review and approve the PR

@khannakshat7 khannakshat7 requested a review from mayur-tolexo June 2, 2022 06:19
@khannakshat7 khannakshat7 requested a review from mayur-tolexo June 2, 2022 07:55
mayur-tolexo
mayur-tolexo reviewed Jun 2, 2022
View reviewed changes
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
agent/reconciler/host_reconciler.go Outdated Show resolved Hide resolved
@khannakshat7 khannakshat7 requested a review from mayur-tolexo June 2, 2022 13:47
anusha94
anusha94 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for the changes 🎉

@anusha94 anusha94 merged commit c7fb265 into vmware-tanzu:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham14bajpai shubham14bajpai shubham14bajpai approved these changes

@anusha94 anusha94 anusha94 approved these changes

@dharmjit dharmjit Awaiting requested review from dharmjit

@mayur-tolexo mayur-tolexo Awaiting requested review from mayur-tolexo

Assignees
No one assigned
Labels
area/apis area/test-release cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host Agent changes for executing install and uninstall script
7 participants
@khannakshat7 @codecov-commenter @dharmjit @anusha94 @shubham14bajpai @mayur-tolexo @vmwclabot