Added manual CSR approval flow #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinkumarsingh092
force-pushed
the
add-manual-csr-approval-flow
branch
from
dc52a0b to
70d5eba
Compare
Signed-off-by: Sachin Kumar Singh <[email protected]>
sachinkumarsingh092
force-pushed
the
add-manual-csr-approval-flow
branch
from
70d5eba to
9daecee
Compare
dharmjit
approved these changes
May 25, 2022
|
Should I write an e2e test for this? I don’t see any tests for the manager otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sachin Kumar Singh [email protected]
What this PR does / why we need it:
It should be possible to approve CSR manually. For that, we will disable the ByoAdmission controller by applying it behind an environment variable. Now user can apply the variable
MANUAL_CSR_APPROVAL=trueto manually approve the CSR. By default, the controller will approve the CSRs.File changes:
MANUAL_CSR_APPROVALenvironment variable.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #557
Additional information
I've disabled the cyclometric complexity form
main()due to lots of inevitableifconditions that might even increase in the future and thus increase the complexity further.Another way is to refactor the controller and webhook setup out of the main.