Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: Byoh hostinfo.architecture is not matching with the supported bundle name #551

Merged
merged 1 commit into from
May 20, 2022

Conversation

mayur-tolexo
Copy link
Contributor

@mayur-tolexo mayur-tolexo commented May 19, 2022

What this PR does / why we need it:
Byoh hostinfo.architecture is not matching with the supported bundle name.
Solution:
in installer, replaced the new architecture name with the old one to
match with the bundle name.

Extra changes

  • fixed download package script command as output directory need to be created before pulling the bundle.
  • Executed firewall enable/disable command only if ufw command exists.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #547

Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…bundle name

in installer package, replaced the new architecture name with the old one to
match with the bundle name

Signed-off-by: Mayur Das <[email protected]>
@shubham14bajpai shubham14bajpai merged commit 1917890 into vmware-tanzu:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Byoh hostinfo.architecture is not matching with the supported bundle name
4 participants