Add K8sInstallerConfigTemplate CRD #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha94
previously approved these changes
May 6, 2022
|
Test coverage is shown as decreasing by 3.44%. Could you rebase the PR with main? |
Signed-off-by: Shubham <[email protected]>
shubham14bajpai
dismissed stale reviews from sachinkumarsingh092, anusha94, and mayur-tolexo
via
6c0f828
shubham14bajpai
force-pushed
the
installerTemplate
branch
from
f5df2cc to
6c0f828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham [email protected]
What this PR does / why we need it:
This PR adds the k8sInstallerConfigTemplate CRD which is required to generate K8sInstallerConfig CRs for each BYOMachine. There will different templates for controller and worker nodes similar to BYOMachineTemplates and BYOMachine controller will be responsible for creating the K8sInstallerConfig.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Additional information
Special notes for your reviewer