-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host platform to ByoHost CR info on registration #516
Conversation
Codecov Report
@@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 63.88% 63.65% -0.23%
==========================================
Files 25 25
Lines 1902 1934 +32
==========================================
+ Hits 1215 1231 +16
- Misses 608 624 +16
Partials 79 79
|
4dce41d
to
e3308b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fe94282
to
7928e8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Shubham Bajpai <[email protected]>
Signed-off-by: Shubham Bajpai <[email protected]>
Signed-off-by: Shubham <[email protected]>
Signed-off-by: Shubham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Shubham Bajpai [email protected]
What this PR does / why we need it:
This PR adds the host platform information (arch/os/distribution) to the ByoHost CR when the agent registers the host. Tested the same locally and this is what the CR would look like.
This PR also adds additional printers for the Byohost CRD and with those the output would look like this:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #470
Additional information
The function added in this PR fetches information directly from files from the underneath operating system. Hence not sure how to add a test for the same.
Special notes for your reviewer