Implement low level admission handler interface for ByoHost webhook #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To intercept the ByoHost req object, implementing the low level Handle function. Fix and refactor existing test and code for byohost webhook
Codecov Report
@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 67.11% 67.22% +0.11%
==========================================
Files 22 22
Lines 1721 1730 +9
==========================================
+ Hits 1155 1163 +8
Misses 494 494
- Partials 72 73 +1
|
anusha94
force-pushed
the
byohost-admission-webhook
branch
from
6569f19 to
23ea765
Compare
anusha94
force-pushed
the
byohost-admission-webhook
branch
from
af4c42d to
04dcef9
Compare
dharmjit
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To intercept the ByoHost req object, implementing the low level Handle
function.
Fix and refactor existing test and code for byohost webhook
Partial fix for #514