Add admission controller #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 63.88% 64.15% +0.27%
==========================================
Files 25 27 +2
Lines 1902 1992 +90
==========================================
+ Hits 1215 1278 +63
- Misses 608 633 +25
- Partials 79 81 +2
|
dharmjit
reviewed
Apr 29, 2022
anusha94
reviewed
May 2, 2022
CSR registration wnd BootstrapAuthenticator will be handled behind SecureAccess feature flag. CSR resource will be created in the management cluster on the start of the HostAgent. BootstrapAuthenticator controller will watch the CSR resources. Currently placeholders are created for different flows and the implementation will be raised in differemt PRs
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
dharmjit
reviewed
May 5, 2022
Signed-off-by: Sachin Kumar Singh <[email protected]>
dharmjit
reviewed
May 9, 2022
Signed-off-by: Sachin Kumar Singh <[email protected]>
anusha94
reviewed
May 11, 2022
Signed-off-by: Sachin Kumar Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A new controller, called the ByoAdmission controller, would automatically approve these requests and admit the hosts into the capacity pool.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #499
Additional information
Changes for admission controller:
Special notes for your reviewer
This builds on top of #510 so will have some overlapping commits. Once that is merged, we can rebase it.