Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding use-installer-flag to host agent #502

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

anusha94
Copy link
Contributor

@anusha94 anusha94 commented Apr 25, 2022

  • this flag indicates we have to use the script provided by the
    installer controller
  • added a new Reason for this flag
  • refactored skip-installation code path
  • added unit and integration tests cases

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #464

- this flag indicates we have to use the script provided by the
  installer controller
- refactored skip-installation code path
- added unit and integration tests cases
@anusha94 anusha94 marked this pull request as draft April 25, 2022 13:13
@anusha94 anusha94 marked this pull request as ready for review April 25, 2022 18:31
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sachinkumarsingh092 sachinkumarsingh092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anusha94 anusha94 merged commit a583ab5 into vmware-tanzu:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce new flag for host agent to install k8s from a script
4 participants