-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ClusterRole and ClusterRoleBindings for CSR #498
Merged
sachinkumarsingh092
merged 4 commits into
vmware-tanzu:main
from
sachinkumarsingh092:cluster-rbac-csr
Apr 21, 2022
Merged
Add new ClusterRole and ClusterRoleBindings for CSR #498
sachinkumarsingh092
merged 4 commits into
vmware-tanzu:main
from
sachinkumarsingh092:cluster-rbac-csr
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
anusha94
previously approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dharmjit
reviewed
Apr 21, 2022
sachinkumarsingh092
force-pushed
the
cluster-rbac-csr
branch
from
April 21, 2022 07:11
4f5132a
to
035f834
Compare
dharmjit
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
shubham14bajpai
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces new ClusterRole and ClusterRoleBindings to allow the Bootstrap authenticator controller in the host to create, get and watch CSRs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #485
Additional information
Changes in brief:
csr-creator-clusterrole
with create, get and watch permission.make manifests
)