Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ClusterRole and ClusterRoleBindings for CSR #498

Merged

Conversation

sachinkumarsingh092
Copy link
Contributor

What this PR does / why we need it:
This PR introduces new ClusterRole and ClusterRoleBindings to allow the Bootstrap authenticator controller in the host to create, get and watch CSRs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #485

Additional information
Changes in brief:

  • config/rbac/csr_creator_clusterrole.yaml: The new clusterRole named csr-creator-clusterrole with create, get and watch permission.
  • config/rbac/csr_creator_clusterrolebinding.yaml: The clusterRoleBinding for the above clusterRole.
  • config/rbac/role.yaml: The rbac for the CSR resource for the manager (generated by make manifests)
  • controllers/infrastructure/byohost_controller.go: The marker for the RBAC in the manager.

anusha94
anusha94 previously approved these changes Apr 20, 2022
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sachinkumarsingh092 sachinkumarsingh092 merged commit 85a9dd7 into vmware-tanzu:main Apr 21, 2022
@sachinkumarsingh092 sachinkumarsingh092 deleted the cluster-rbac-csr branch April 21, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new ClusterRoles and ClusterRoleBindings for management cluster
5 participants