Update ByoHost/ ByoMachine CRDs for installer changes #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByoHost will have a optional reference for InstallationSecret, ByoMachine will have an optional reference to InstallerConfig and will also hold the attached ByoHost platform details.
|
lgtm |
shamsher31
reviewed
Apr 20, 2022
Co-authored-by: Shamsher Ansari <[email protected]>
shamsher31
reviewed
Apr 20, 2022
mayur-tolexo
approved these changes
Apr 20, 2022
anusha94
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For the new Installer flow, we need to modify the existing BYO* CRDs. This PR updates
ByoMachinewill have an optional reference toInstallerConfigand will also hold the attachedByoHostplatform details.ByoHostwill have an optional reference forInstallationSecret.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #493