Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OS and K8s version support in README.md #488

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

VibhorChinda
Copy link
Contributor

@VibhorChinda VibhorChinda commented Apr 18, 2022

What this PR does / why we need it:
Added OS and K8s version support in README.md

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #478

Additional information
Earlier BYOH supported only a single version of Ubuntu and k8s. But now we support multiple versions of these.
Here is the list of supported OS and k8s versions. Added the required section in the README.md

Special notes for your reviewer

@VibhorChinda
Copy link
Contributor Author

@sachinkumarsingh092 please have a look :))

Copy link
Contributor

@sachinkumarsingh092 sachinkumarsingh092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

anusha94
anusha94 previously approved these changes Apr 19, 2022
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit.lgtm otherwise.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sachinkumarsingh092 sachinkumarsingh092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sachinkumarsingh092 sachinkumarsingh092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dharmjit dharmjit merged commit a3cfff7 into vmware-tanzu:main Apr 20, 2022
@sachinkumarsingh092
Copy link
Contributor

Congrats @VibhorChinda for your first contribution 🎉

@VibhorChinda VibhorChinda deleted the ReadmeUpdate branch April 20, 2022 18:25
@VibhorChinda
Copy link
Contributor Author

Congrats @VibhorChinda for your first contribution 🎉

Thanks @sachinkumarsingh092 many more to go :)) Hope so hahahahah

@vmwclabot
Copy link

@VibhorChinda, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants