Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fixes #480

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Conversation

sachinkumarsingh092
Copy link
Contributor

@sachinkumarsingh092 sachinkumarsingh092 commented Apr 8, 2022

Signed-off-by: Sachin Kumar Singh [email protected]

What this PR does / why we need it:
Fixes few errors In getting_started

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Additional information

Special notes for your reviewer

Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. But, in the future, can we make sure we have corresponding issue filed before raising a PR ?

docs/getting_started.md Show resolved Hide resolved
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/getting_started.md Show resolved Hide resolved
anusha94
anusha94 previously approved these changes Apr 13, 2022
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dharmjit
dharmjit previously approved these changes Apr 13, 2022
anusha94
anusha94 previously approved these changes Apr 19, 2022
Signed-off-by: Sachin Kumar Singh <[email protected]>
Copy link
Contributor

@pshail pshail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dharmjit dharmjit merged commit 04b3b81 into vmware-tanzu:main Apr 20, 2022
@sachinkumarsingh092 sachinkumarsingh092 deleted the docs-fixes branch April 20, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants