Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s & capi dependencies #476

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Apr 5, 2022

Signed-off-by: Shubham Bajpai [email protected]

What this PR does / why we need it:

This PR bumps the following components to maintain sync with cluster-api, inspired by the slack thread:

  • Golang to v1.17 in go.mod, github-actions, Dockerfiles, Makefile. Also fixes the golangci-lint issue.
  • klog/v1 to klog/v2, this will break as controller-runtime v0.10.3 is not compatible
  • CAPI to v1.1.3, this will automatically fix the above as controller-runtime is a dependency. This will break as impkg v0.18.0 is not compatible.
  • impkg to v0.21.0 and kube-vip to v0.4.1 to maintain sync with the kube-vip images in templates

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #463

Additional information

Special notes for your reviewer

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #476 (9ffed1f) into main (b17b4f0) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   67.19%   67.11%   -0.08%     
==========================================
  Files          22       22              
  Lines        1719     1721       +2     
==========================================
  Hits         1155     1155              
- Misses        492      494       +2     
  Partials       72       72              
Impacted Files Coverage Δ
agent/main.go 15.89% <0.00%> (-0.22%) ⬇️

@shubham14bajpai shubham14bajpai force-pushed the bump branch 2 times, most recently from a0d4136 to d083001 Compare April 6, 2022 05:36
Signed-off-by: Shubham Bajpai <[email protected]>
Signed-off-by: Shubham Bajpai <[email protected]>
go.mod Show resolved Hide resolved
Signed-off-by: Shubham Bajpai <[email protected]>
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sachinkumarsingh092
Copy link
Contributor

lgtm

@anusha94 anusha94 merged commit b69dcf2 into vmware-tanzu:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump golang and CAPI versions
5 participants