Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s version in e2e tests #455

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

anusha94
Copy link
Contributor

@anusha94 anusha94 commented Mar 24, 2022

  • updated e2e k8s version to v1.23.5
  • updated corresponding Dockerfiles
  • pushed a new bundle to Harbor
  • minor corrections to docs

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #413 #415

Additional information
New OCI image pushed to Harbor. You can check with docker pull projects.registry.vmware.com/cluster_api_provider_bringyourownhost/byoh-bundle-ubuntu_20.04.1_x86-64_k8s:v1.23.5

@anusha94 anusha94 force-pushed the e2e-k8s-bump branch 2 times, most recently from 11c4ec6 to 5a0d806 Compare April 6, 2022 09:58
anusha94 added 3 commits April 6, 2022 10:13
- updated e2e k8s version to v1.23.4
- updated corresponding Dockerfiles
- pushed a new bundle to Harbor
- minor corrections to docs
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dharmjit
Copy link
Contributor

dharmjit commented Apr 6, 2022

@anusha94, as BYOH is supporting n-2 k8s minor versions, we need to push maybe the latest patch version of these minor k8s releases and also had to include e2e tests for different k8s versions. wdyt?

Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anusha94
Copy link
Contributor Author

anusha94 commented Apr 6, 2022

we need to push maybe the latest patch version of these minor k8s releases and also had to include e2e tests for different k8s versions. wdyt?

@dharmjit I'm looking at jobs for CAPI - https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/cluster-api
They seem to test the latest stable version in e2e and an upgrade test would test n-1 to n
So this seems sufficient to me now.

@anusha94 anusha94 merged commit b4b9f89 into vmware-tanzu:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update e2e test to use latest K8s version
5 participants