-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions information in HostAgent binary #454
Merged
sachinkumarsingh092
merged 10 commits into
vmware-tanzu:main
from
sachinkumarsingh092:version-hostagent-bin
Mar 31, 2022
Merged
Update versions information in HostAgent binary #454
sachinkumarsingh092
merged 10 commits into
vmware-tanzu:main
from
sachinkumarsingh092:version-hostagent-bin
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 67.69% 67.19% -0.51%
==========================================
Files 23 22 -1
Lines 1746 1719 -27
==========================================
- Hits 1182 1155 -27
Misses 492 492
Partials 72 72
|
Signed-off-by: Anusha Hegde <[email protected]>
Signed-off-by: Sachin Singh <[email protected]>
|
sachinkumarsingh092
force-pushed
the
version-hostagent-bin
branch
from
March 24, 2022 22:21
02c0e7b
to
6087a9a
Compare
For the new test, we match the script generated values and locally created git values.
sachinkumarsingh092
force-pushed
the
version-hostagent-bin
branch
from
March 24, 2022 22:24
6087a9a
to
c8221ee
Compare
shamsher31
reviewed
Mar 25, 2022
anusha94
reviewed
Mar 31, 2022
Co-authored-by: Anusha Hegde <[email protected]>
anusha94
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
dharmjit
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The version flag in the host agent binary displays the major, minor and patch versions.
This PR introduces the following flags, similar to kubectl or clusterctl, and removes the patch field from version information.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #436
Additional information
Changes:
hack/version.sh
script so no need forAGENT_BINARY_VERSION
.ldflags
that are generated from the version.sh script.ldflags
during building the binary.git describe
to extract all the information required for different fields. This is taken formsigs.k8s.io/cluster-api/hack/version.sh
.Special notes for your reviewer