Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor indentation and readability improvements #442

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

shubham14bajpai
Copy link
Contributor

Signed-off-by: Shubham Bajpai [email protected]

What this PR does / why we need it:
This PR fixes minor indentation issues and removes $ from shell commands for better copy-paste experience :)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Additional information

Special notes for your reviewer

@sachinkumarsingh092
Copy link
Contributor

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #442 (c9e8a35) into main (b17b4f0) will increase coverage by 1.06%.
The diff coverage is n/a.

❗ Current head c9e8a35 differs from pull request most recent head 2794ace. Consider uploading reports for the commit 2794ace to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   67.19%   68.25%   +1.06%     
==========================================
  Files          22       23       +1     
  Lines        1719     1720       +1     
==========================================
+ Hits         1155     1174      +19     
+ Misses        492      474      -18     
  Partials       72       72              
Impacted Files Coverage Δ
agent/installer/bundle_downloader.go 68.23% <0.00%> (-1.43%) ⬇️
agent/installer/installer.go 77.57% <0.00%> (-0.54%) ⬇️
agent/installer/registry.go 100.00% <0.00%> (ø)
agent/cloudinit/cloudinit.go 76.66% <0.00%> (ø)
agent/cloudinit/cmd_runner.go 100.00% <0.00%> (ø)
agent/cloudinit/file_writer.go 29.23% <0.00%> (ø)
agent/cloudinit/template_parser.go 50.00% <0.00%> (ø)
agent/reconciler/host_reconciler.go 79.23% <0.00%> (ø)
agent/installer/internal/algo/apt_step.go 100.00% <0.00%> (ø)
agent/installer/internal/algo/installer.go 86.15% <0.00%> (ø)
... and 9 more

@anusha94 anusha94 merged commit b83b1be into vmware-tanzu:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants