Wait for the host agent process to start in host agent integration tests

[anusha94]

Since we are running the host agent in the containers for integration
tests, the process is not started instantly sometimes and this causes
flakes in the tests. Adding a check to ensure the host agent process is
started and only then proceed with the tests

Signed-off-by: Nilanjan Daw [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #438

[codecov-commenter]

Codecov Report

Merging #441 (bcea510) into main (3e0b04f) will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   67.97%   68.40%   +0.42%     
==========================================
  Files          23       23              
  Lines        1705     1728      +23     
==========================================
+ Hits         1159     1182      +23     
  Misses        474      474              
  Partials       72       72              

Impacted Files	Coverage Δ
agent/version/version.go	100.00% <0.00%> (ø)
agent/installer/registry.go	100.00% <0.00%> (ø)
agent/cloudinit/cloudinit.go	76.66% <0.00%> (ø)
agent/cloudinit/cmd_runner.go	100.00% <0.00%> (ø)
agent/cloudinit/file_writer.go	29.23% <0.00%> (ø)
agent/cloudinit/template_parser.go	50.00% <0.00%> (ø)
agent/reconciler/host_reconciler.go	79.23% <0.00%> (ø)
agent/installer/internal/algo/apt_step.go	100.00% <0.00%> (ø)
agent/installer/internal/algo/installer.go	86.15% <0.00%> (ø)
apis/infrastructure/v1beta1/byohost_webhook.go	87.50% <0.00%> (ø)
... and 8 more

[dharmjit]

lgtm

[jamiemonserrate]

I think this makes sense, and is a good incremental step to improving the flakiness. I am slightly worried that this check might pass wrongly if there is any process that matches the name agent. But this is a good start.

But is this enough? That is, should we be checking if the host-agent has reached a desired state? Like maybe the log messages should say "agent started/ready" or something?

Just a suggestion, as I'm not sure what exactly we need to wait for.

[anusha94]

But is this enough? That is, should we be checking if the host-agent has reached a desired state? Like maybe the log messages should say "agent started/ready" or something?

Good suggestion, if the flakiness persists, we could try that.