-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for K8s minor versions v1.21.* & v1.23.* to the Installer #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilar to the OS one" This reverts commit fdbfbb2.
…specified when calling the addBundleInstaller - it now defaults to v1.22.3 if no k8s ver is specified
…bversion is accepted if supported Major and Minor versions are present.
This reverts commit eb3a033.
This reverts commit eb3a033. There is a separate issue for this task.
…tency reasons; Updated the registry e2e tests
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 68.25% 68.32% +0.07%
==========================================
Files 23 23
Lines 1720 1724 +4
==========================================
+ Hits 1174 1178 +4
Misses 474 474
Partials 72 72
|
dharmjit
reviewed
Mar 21, 2022
anusha94
reviewed
Mar 21, 2022
dharmjit
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anusha94
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests in a subsequent PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support to the Installer for Kubernetes minor versions v1.21.* and v1.23.*
Note that both of those minor versions have no differences in their steps provider so they are using the same installation algorithm as v1.22.*
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #412