Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for K8s minor versions v1.21.* & v1.23.* to the Installer #440

Merged
merged 22 commits into from
Mar 22, 2022

Conversation

jeuxdemains
Copy link
Contributor

@jeuxdemains jeuxdemains commented Mar 21, 2022

What this PR does / why we need it:
This PR adds support to the Installer for Kubernetes minor versions v1.21.* and v1.23.*
Note that both of those minor versions have no differences in their steps provider so they are using the same installation algorithm as v1.22.*

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #412

…specified when calling the addBundleInstaller - it now defaults to v1.22.3 if no k8s ver is specified
…bversion is accepted if supported Major and Minor versions are present.
This reverts commit eb3a033.

There is a separate issue for this task.
…tency reasons; Updated the registry e2e tests
@codecov-commenter
Copy link

Codecov Report

Merging #440 (8111fb4) into main (58e5a39) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   68.25%   68.32%   +0.07%     
==========================================
  Files          23       23              
  Lines        1720     1724       +4     
==========================================
+ Hits         1174     1178       +4     
  Misses        474      474              
  Partials       72       72              
Impacted Files Coverage Δ
agent/installer/installer.go 78.10% <100.00%> (+0.53%) ⬆️

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests in a subsequent PR

@dharmjit dharmjit merged commit cc605cf into vmware-tanzu:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support K8s v1.21, v1.23 minor series
5 participants