Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds default goal for Makefile. #407

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

jaybatra26
Copy link
Contributor

@jaybatra26 jaybatra26 commented Mar 1, 2022

make doesn't provide default target options.
This PR adds a default goal for the same.

Signed-off-by: Jaybatra [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #408

Additional information

Special notes for your reviewer

`make` doesn't provide default target options.
This PR adds a default goal for the same.

Signed-off-by: Jaybatra <[email protected]>
@vmwclabot
Copy link

@jaybatra26, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@anusha94
Copy link
Contributor

anusha94 commented Mar 1, 2022

@jaybatra26
Thank you for the PR!
Can you please sign the VMware CLA?

Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to BYOH 🎉

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jaybatra26 for your contribution 👍

@dharmjit dharmjit merged commit 2e454af into vmware-tanzu:main Mar 2, 2022
@vmwclabot
Copy link

@jaybatra26, VMware has approved your signed contributor license agreement.

@jaybatra26 jaybatra26 deleted the make branch March 13, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default goal is missing for Makefile
4 participants