Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host-agent integration tests #399

Merged

Conversation

NilanjanDaw
Copy link
Contributor

@NilanjanDaw NilanjanDaw commented Feb 24, 2022

What this PR does / why we need it:
Add integration tests for installK8sComponents. Also updates the existing host-agent tests to run within docker-based environments.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #393

@NilanjanDaw NilanjanDaw added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress label Feb 24, 2022
@NilanjanDaw NilanjanDaw changed the title Add integration test for host-agent Add support functions for host-agent integration test Feb 25, 2022
@NilanjanDaw NilanjanDaw changed the title Add support functions for host-agent integration test Add host-agent integration tests Feb 25, 2022
@NilanjanDaw NilanjanDaw force-pushed the add_reconciler_integration_tests branch from c856add to 0109602 Compare March 4, 2022 05:13
@NilanjanDaw NilanjanDaw removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress label Mar 4, 2022
@NilanjanDaw NilanjanDaw marked this pull request as ready for review March 4, 2022 05:14
@NilanjanDaw NilanjanDaw force-pushed the add_reconciler_integration_tests branch from 16bd7a4 to ac0f8c0 Compare March 4, 2022 09:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #399 (c103eb1) into main (00b281d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files          23       23           
  Lines        1705     1705           
=======================================
  Hits         1159     1159           
  Misses        474      474           
  Partials       72       72           
Impacted Files Coverage Δ
agent/main.go 18.32% <0.00%> (ø)

Makefile Outdated Show resolved Hide resolved
agent/host_agent_suite_test.go Show resolved Hide resolved
agent/host_agent_suite_test.go Show resolved Hide resolved
agent/host_agent_test.go Outdated Show resolved Hide resolved
agent/host_agent_test.go Outdated Show resolved Hide resolved
agent/host_agent_test.go Outdated Show resolved Hide resolved
agent/host_agent_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some nits only

agent/host_agent_suite_test.go Outdated Show resolved Hide resolved
agent/host_agent_test.go Show resolved Hide resolved
@NilanjanDaw NilanjanDaw requested review from dharmjit and anusha94 March 7, 2022 07:41
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Thank you for this PR!

agent/host_agent_test.go Show resolved Hide resolved
@anusha94 anusha94 merged commit 82a73a4 into vmware-tanzu:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for agent/reconciler
5 participants